ci: add self-hosted PR workflow for same-repo pull requests#403
ci: add self-hosted PR workflow for same-repo pull requests#403terasakisatoshi merged 9 commits intomainfrom
Conversation
Fork PRs use ubuntu-22.04 with full setup; same-repo PRs run tests on self-hosted runners (linux/x64/fast-ci) to offload heavy workloads. Made-with: Cursor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85c0d6f6ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Run tests (non-HDF5) | ||
| run: cargo nextest run --release --workspace --exclude tensor4all-hdf5 |
There was a problem hiding this comment.
The ci-maintainer path only runs cargo nextest ... --exclude tensor4all-hdf5 and never runs a replacement cargo test -p tensor4all-hdf5, unlike the fork path in the same workflow. As a result, same-repo PRs validated by this workflow can merge with regressions in tensor4all-hdf5 undetected.
Useful? React with 👍 / 👎.
Added CARGO_TARGET_DIR and CARGO_PROFILE_RELEASE_DEBUG to the self-hosted CI workflow for improved build configuration. Included a step to display the target directory during the CI process.
Updated the CARGO_TARGET_DIR environment variable in the self-hosted CI workflow to use a relative path based on the GitHub workspace, improving build directory management.
Updated the CI workflow name to 'CI_rs_selfhost' and added a new step to run HDF5 tests, enhancing the testing coverage for the project.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fbd2e7ca9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| on: | ||
| pull_request: | ||
| branches: [main] |
There was a problem hiding this comment.
This workflow triggers on every pull_request to main, but CI_rs.yml already does the same (pull_request on main/develop), so each PR to main now runs two near-identical Rust test pipelines in parallel (fork PRs: CI_rs test + ci-fork; same-repo PRs: CI_rs test + ci-maintainer). That doubles CI load and queue time, and can starve self-hosted capacity without adding new validation coverage.
Useful? React with 👍 / 👎.
Commented out the entire test job in the CI workflow to streamline the process, potentially for debugging or reconfiguration purposes.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6dc424297
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| steps: | ||
| - uses: actions/checkout@v4 | ||
| # testジョブ全体を無効化 | ||
| # test: |
There was a problem hiding this comment.
Commenting out the test job here removes release/tensor4all-hdf5 test execution from CI_rs.yml, but the replacement workflow only triggers for pull_request to main (CI_rs_selfhost.yml), so PRs targeting develop and all push runs no longer get the previous test coverage. That creates a real gap where regressions can pass CI undetected in those paths.
Useful? React with 👍 / 👎.
1 participant
Summary
Adds
.github/workflows/CI_rs_selfhost.ymlfor pull requests targetingmain:ubuntu-22.04with HDF5 and the same test split as existing CI.[self-hosted, linux, x64, fast-ci]for heavier runs.Concurrency is per PR number with
cancel-in-progress.